Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back modifiers in front of signatures #1337

Merged
merged 5 commits into from
May 13, 2024

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented May 9, 2024

Part of #1287

This PR adds modifiers to the signatures of our API components. We continue removing the modifiers for attributes and properties given that we don't show their signature on the website.

This change should be merged after changing the MDX components on IQP to support the new prop.

@arnaucasau arnaucasau changed the title ]Add back modifier in front of signatures [WIP] Add back modifier in front of signatures May 9, 2024
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@arnaucasau arnaucasau marked this pull request as draft May 9, 2024 17:24
@arnaucasau arnaucasau changed the title [WIP] Add back modifier in front of signatures Add back modifiers in front of signatures May 10, 2024
@arnaucasau arnaucasau marked this pull request as ready for review May 10, 2024 10:07
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Please wait to merge this until the internal change has landed & docs are synced.

@arnaucasau arnaucasau marked this pull request as draft May 10, 2024 14:25
@arnaucasau arnaucasau marked this pull request as ready for review May 13, 2024 13:55
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@arnaucasau arnaucasau added this pull request to the merge queue May 13, 2024
Merged via the queue into Qiskit:main with commit bb39ba7 May 13, 2024
5 checks passed
@arnaucasau arnaucasau deleted the AC/add-class-label branch May 13, 2024 14:39
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
Part of  #1287
Follow-up of #1337

This PR regenerates the API docs incorporating the changes of #1337.
This is split into two PRs to help in the review of the changes to the
script and due to the amount of files modified. Here we can find all
versions except qiskit 1.0 which was generated in #1337 to review it
more exhaustively.

This change should be merged after changing the MDX components on IQP to
support the new prop.
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Part of  Qiskit#1287

This PR adds modifiers to the signatures of our API components. We
continue removing the modifiers for attributes and properties given that
we don't show their signature on the website.

This change should be merged after changing the MDX components on IQP to
support the new prop.
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Part of  Qiskit#1287
Follow-up of Qiskit#1337

This PR regenerates the API docs incorporating the changes of Qiskit#1337.
This is split into two PRs to help in the review of the changes to the
script and due to the amount of files modified. Here we can find all
versions except qiskit 1.0 which was generated in Qiskit#1337 to review it
more exhaustively.

This change should be merged after changing the MDX components on IQP to
support the new prop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants